Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new version not pushed on github #871

Closed
msuret opened this issue Jun 18, 2015 · 4 comments
Closed

new version not pushed on github #871

msuret opened this issue Jun 18, 2015 · 4 comments

Comments

@msuret
Copy link

msuret commented Jun 18, 2015

Hi,
I'm using rultor to release to Maven Central.
Everything works fine, except that the pom.xml with the new version is not pushed on github: It looks like Rultor is resetting and deleting its branch before pushing.
The project is here and the log here.
What am I doing wrong ?

Thanks a lot !

@yegor256
Copy link
Owner

@msuret I can't understand what's going on... take a look at a similar log: http://www.rultor.com/t/3549-96025647 It's done in this project: https://github.com/jcabi/jcabi-github/releases/tag/0.23 Its tail looks exactly the same as yours, but it does create a new tag in Github.

Maybe it's a temporary issue with Github?

@msuret
Copy link
Author

msuret commented Jun 19, 2015

@yegor256 You're right, I asked rultor to release it again today and the tag has been created.
But my question was more about how to push the pom.xml after it is updated by the Versions Maven Plugin and before the tag is created.
I worked around this by adding these commands in rultor release script:

git checkout master
git merge __rultor

Is there a cleaner way to do it ?

@yegor256
Copy link
Owner

@msuret you don't need to do it manually. It happens automatically. You just do git commit (already in your script) and rultor automatically tags that branch. So, the changes should not be in master, but only in the tag. Here is your tag: https://github.com/dhatim/business-hours-java/tree/1.0.0 As you see, pom.xml is modified

@msuret
Copy link
Author

msuret commented Jun 19, 2015

@yegor256 Thanks a lot! I'm closing the issue.

@msuret msuret closed this as completed Jun 19, 2015
davherrmann added a commit to davherrmann/immutable that referenced this issue May 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants