added tests for VerboseIterable and VerboseIterator #125
Conversation
|
Many thanks for the PR, let me find a reviewer for it |
|
@ggajos review this one,please |
|
@celezar please fix qulice issues |
| public ExpectedException expectedEx = ExpectedException.none(); | ||
|
|
||
| @Test | ||
| public void testIterator() throws Exception { |
There was a problem hiding this comment.
@celezar see http://www.yegor256.com/2014/04/27/typical-mistakes-in-java-code.html#test-method-names for test name and test description.
|
@ggajos I have made the changes so there are no more qulice issues. I had some problem with running qulice test from Idea but was able to do so from CLI. I disabled some rules. VisibilityModifierCheck was necessary to disable on field expected. |
| private static String two = "2"; | ||
| private static String three = "3"; | ||
| private static String errormessage = "Error message"; | ||
|
|
There was a problem hiding this comment.
@celezar let's avoid extracting fields when used only once
There was a problem hiding this comment.
they are used at least two times. i extracted them because qulice was complaining.
There was a problem hiding this comment.
@celezar you can try to use different string, let's not couple tests together
|
@celezar all good, just few comments |
|
@celezar any update here? |
|
@ggajos i have asked for reassignment of this task |
|
@celezar ok, so we can close this PR without merge right? |
|
@ggajos i guess so but not sure what the procedure is. i have requested reassignment but it is still not assigned to someone else. |
|
@celezar just close the pull request and that's it |
|
@elenavolokhova please, review this task for compliance with our quality rules |
|
@davvd Despite this PR was not merged, reviewer did his work well and should be rewarded. Still it can't be marked as perfect. |
|
@davvd Quality is acceptable. |
@elenavolokhova thanks a lot, next time everybody should try to make it better |
|
@ggajos I added 10 mins to @elenavolokhova (for QA review) in transaction 56843371... 19 mins sent to your balance (ID |
I have created testst for VerboseIterable and VerboseIterator as requested in issue #111.