Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#978 Update cactoos to 0.41 #985

Merged
merged 4 commits into from Sep 6, 2019
Merged

Conversation

golszewski86
Copy link
Contributor

#978 Cactoos updated to 0.41.
Use renamed classes from Cactoos.
Where necessary, imports order changes to please Qulice.

@0crat 0crat added the scope label Jun 4, 2019
@0crat
Copy link
Collaborator

0crat commented Jun 4, 2019

Job #985 is now in scope, role is REV

@0crat
Copy link
Collaborator

0crat commented Jun 4, 2019

This pull request #985 is assigned to @marceloamadeu/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

@marceloamadeu
Copy link
Contributor

@0crat refuse

@0crat
Copy link
Collaborator

0crat commented Jun 6, 2019

@0crat refuse (here)

@marceloamadeu The user @marceloamadeu/z resigned from #985, please stop working. Reason for job resignation: Order was cancelled

@0crat
Copy link
Collaborator

0crat commented Jun 6, 2019

Tasks refusal is discouraged, see §6: -15 point(s) just awarded to @marceloamadeu/z

@0crat
Copy link
Collaborator

0crat commented Jun 6, 2019

This pull request #985 is assigned to @lucasmessias9898/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

@piotrkot
Copy link
Contributor

piotrkot commented Aug 6, 2019

@golszewski86 I'm interested in getting this one merged. Can you please resolve the conflicts? Or maybe I can clone your PR?

@golszewski86
Copy link
Contributor Author

golszewski86 commented Aug 7, 2019

Hi @yegor256 ,
The build in Travis CI fails on installing JDK with the following error:

Expected feature release number in range of 9 to 14, but got: 8
The command "~/bin/install-jdk.sh --target "/home/travis/oraclejdk8" --workspace "/home/travis/.cache/install-jdk" --feature "8" --license "BCL"" failed and exited with 3 during .

Builds of branch master fail due to the same error. Could you please fix build configuration on Travis CI so we could proceed with this pull request?
FYI @paulodamaso

@golszewski86
Copy link
Contributor Author

@yegor256 @paulodamaso ping

@paulodamaso
Copy link
Contributor

@golszewski86 Please open an issue about it

@piotrkot
Copy link
Contributor

piotrkot commented Sep 6, 2019

@0crat help

@0crat
Copy link
Collaborator

0crat commented Sep 6, 2019

@0crat help (here)

@piotrkot Can't understand "help", try one of these:

  • assign Assign a performer to this issue
  • boost Set a boost for the job
  • continue Remove a job's impediment
  • hello Just say hello
  • in Register this issue in scope (WBS)
  • out Close the order and remove this job from scope
  • pay Pay a user some extra cash
  • quality Review a task
  • resign Resign from this issue
  • status Check the status of the job
  • version Print current version of the bot
  • wait Register an impediment for a job

@piotrkot
Copy link
Contributor

piotrkot commented Sep 6, 2019

@paulodamaso Is there a command to instruct 0crat to rebuild on Travis?

@piotrkot
Copy link
Contributor

piotrkot commented Sep 6, 2019

@paulodamaso This PR was assigned to @lucasmessias9898 since Jun 6. As we haven't heard from him, can we change the reviewer?

@paulodamaso
Copy link
Contributor

@piotrkot For sure, let me do it

@paulodamaso
Copy link
Contributor

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Sep 6, 2019

@rultor merge

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 6e5bf2f into yegor256:master Sep 6, 2019
@rultor
Copy link
Collaborator

rultor commented Sep 6, 2019

@rultor merge

@paulodamaso Done! FYI, the full log is here (took me 31min)

@golszewski86
Copy link
Contributor Author

Thank you @paulodamaso . I'd appreciate if you could release version with those changes.

@paulodamaso
Copy link
Contributor

@rultor release tag is 1.18

@rultor
Copy link
Collaborator

rultor commented Sep 6, 2019

@rultor release tag is 1.18

@paulodamaso OK, I will release it now. Please check the progress here

@0crat 0crat removed the scope label Sep 6, 2019
@0crat
Copy link
Collaborator

0crat commented Sep 6, 2019

Code review was too long (92 days), architects (@paulodamaso) were penalized, see §55

@0crat
Copy link
Collaborator

0crat commented Sep 6, 2019

@sereshqua/z please review this job completed by @lucasmessias9898/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat
Copy link
Collaborator

0crat commented Sep 6, 2019

The job #985 is now out of scope

@sereshqua
Copy link

@0crat quality bad

@0crat
Copy link
Collaborator

0crat commented Sep 6, 2019

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @paulodamaso/z

@0crat
Copy link
Collaborator

0crat commented Sep 6, 2019

Quality is low, no payment, see §31

@rultor
Copy link
Collaborator

rultor commented Sep 6, 2019

@rultor release tag is 1.18

@paulodamaso Done! FYI, the full log is here (took me 23min)

@0crat
Copy link
Collaborator

0crat commented Sep 6, 2019

Quality review completed: +4 point(s) just awarded to @sereshqua/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants