Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread safe Mono #39

Closed
volodya-lombrozo opened this issue Oct 24, 2022 · 9 comments
Closed

Thread safe Mono #39

volodya-lombrozo opened this issue Oct 24, 2022 · 9 comments

Comments

@volodya-lombrozo
Copy link
Contributor

During solving the eo issue we faced with the concurrency problem. The problem in MnCsv - it's not a thread safe class. I suggest to implement something like ThreadSafeMono which will make read/write locks for both methods. In other words, we need a thread safe implementation of Mono as a decorator for other Mono classes.

@l3r8yJ
Copy link
Contributor

l3r8yJ commented Oct 24, 2022

@volodya-lombrozo @yegor256 can i help you here? if so, does it make sense to make read() method locked?

@yegor256
Copy link
Owner

@l3r8yJ sure, go ahead. Would be nice to have MnSynchronized decorator of Mono, I believe

@volodya-lombrozo
Copy link
Contributor Author

@l3r8yJ I think it makes sense. Otherwise you can read() some garbadge if another thread will be in the middle of the write(), in some cases you can get even an exception. The actuall behaviour will depend on decorated object.

@l3r8yJ
Copy link
Contributor

l3r8yJ commented Oct 24, 2022

@volodya-lombrozo see your point

l3r8yJ added a commit to l3r8yJ/tojos that referenced this issue Oct 24, 2022
l3r8yJ added a commit to l3r8yJ/tojos that referenced this issue Oct 25, 2022
l3r8yJ added a commit to l3r8yJ/tojos that referenced this issue Oct 25, 2022
l3r8yJ added a commit to l3r8yJ/tojos that referenced this issue Oct 25, 2022
l3r8yJ added a commit to l3r8yJ/tojos that referenced this issue Oct 25, 2022
l3r8yJ added a commit to l3r8yJ/tojos that referenced this issue Oct 26, 2022
l3r8yJ added a commit to l3r8yJ/tojos that referenced this issue Oct 26, 2022
l3r8yJ added a commit to l3r8yJ/tojos that referenced this issue Oct 26, 2022
l3r8yJ added a commit to l3r8yJ/tojos that referenced this issue Oct 26, 2022
l3r8yJ added a commit to l3r8yJ/tojos that referenced this issue Oct 26, 2022
l3r8yJ added a commit to l3r8yJ/tojos that referenced this issue Oct 26, 2022
l3r8yJ added a commit to l3r8yJ/tojos that referenced this issue Oct 27, 2022
l3r8yJ added a commit to l3r8yJ/tojos that referenced this issue Oct 27, 2022
l3r8yJ added a commit to l3r8yJ/tojos that referenced this issue Oct 27, 2022
l3r8yJ added a commit to l3r8yJ/tojos that referenced this issue Oct 27, 2022
l3r8yJ added a commit to l3r8yJ/tojos that referenced this issue Oct 27, 2022
l3r8yJ added a commit to l3r8yJ/tojos that referenced this issue Nov 1, 2022
l3r8yJ added a commit to l3r8yJ/tojos that referenced this issue Nov 1, 2022
l3r8yJ added a commit to l3r8yJ/tojos that referenced this issue Dec 1, 2022
l3r8yJ added a commit to l3r8yJ/tojos that referenced this issue Dec 1, 2022
l3r8yJ added a commit to l3r8yJ/tojos that referenced this issue Dec 1, 2022
l3r8yJ added a commit to l3r8yJ/tojos that referenced this issue Dec 1, 2022
l3r8yJ added a commit to l3r8yJ/tojos that referenced this issue Dec 1, 2022
@yegor256
Copy link
Owner

yegor256 commented Dec 2, 2022

@rultor release, tag is 0.15.0

@rultor
Copy link
Collaborator

rultor commented Dec 2, 2022

@rultor release, tag is 0.15.0

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Collaborator

rultor commented Dec 2, 2022

@rultor release, tag is 0.15.0

@yegor256 Done! FYI, the full log is here (took me 5min)

@yegor256
Copy link
Owner

yegor256 commented Dec 2, 2022

@volodya-lombrozo should be fixed in 0.15.0

@yegor256
Copy link
Owner

@volodya-lombrozo should I release a new version here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants