Suppress pandas FutureWarnings

[JPhillips92]

Fixes #156.

[yehoshuadimarsky]

Thanks, but the better solution would be to just replace applymap with map, do you want to do that instead?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.22%. Comparing base (7b471db) to head (a05c166).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #165   +/-   ##
=======================================
  Coverage   94.22%   94.22%           
=======================================
  Files           4        4           
  Lines         277      277           
=======================================
  Hits          261      261           
  Misses         16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yehoshuadimarsky]

looks great thanks. but why are you also changing the minimum python version from 3.8 to 3.9?

[JPhillips92]

Sorry I meant to add a comment about that yesterday. I had to bump python because pandas.DataFrame.map is new for pandas v2.1 ref and it requires python 3.9 or higher ref.

[yehoshuadimarsky]

Sorry but Python 3.8 is still not end-of-life, I don't think we can drop support for it by requiring Python 3.9+

[JPhillips92]

@yehoshuadimarsky That's fair enough. Since we can't use map yet, do you want me to roll this back to the initial 'Suppress pandas FutureWarning' fix or just close it?

[taslater]

@JPhillips92

@yehoshuadimarsky That's fair enough. Since we can't use map yet, do you want me to roll this back to the initial 'Suppress pandas FutureWarning' fix or just close it?

I'm sorry, why can't map be used instead of applymap?