This repository has been archived by the owner on Dec 17, 2019. It is now read-only.
[BUGFIX] xapi-publisher: various fixes #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #97 +/- ##
=======================================
Coverage 0.21% 0.21%
=======================================
Files 56 56
Lines 1364 1364
Branches 111 111
=======================================
Hits 3 3
Misses 1250 1250
Partials 111 111Continue to review full report at Codecov.
|
yeldiRium
approved these changes
Oct 12, 2018
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, the usage of requests was still not right, but didn't get noticed, since TLA did weird stuff when testing yesterday.
Also, the location where xAPI statements are created in TLA is now logged.
Logging for requests that are rejected due to privacy settings is now disabled completely as we can't
save any information on those actors.
This change is