Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python3 batch_iter or use tensorflow data batchsize generator #7

Closed
SrMouraSilva opened this issue Mar 5, 2019 · 3 comments
Closed
Labels

Comments

@SrMouraSilva
Copy link
Contributor

SrMouraSilva commented Mar 5, 2019

utils.py Line 37

# Use // instead /
n_batches = N / batch_size + (N % batch_size > 0)

Python 2: float / int -> int
Python 3: float / int -> float
Python 3: float // int -> int

use tensorflow data batchsize generator

I will add information later

@yell yell added the bug label Mar 5, 2019
@yell
Copy link
Owner

yell commented Mar 5, 2019

Thanks for spotting.
If you find more bugs please add info or perhaps open a PR.
I actually plan to rewrite many things better when I have a bit more spare time, and also to rigorously check python3-compatibility etc.

@SrMouraSilva
Copy link
Contributor Author

SrMouraSilva commented Mar 5, 2019

Hello, Yelysei Bondarenko

I'm working with RBM in master degree. My current implementation in tensorflow might have some problems. I was testing on yours.

There is the possibility that I migrate to your implementation. But I need to work with RBMCF and Conditional RBM. I'm not sure how to do it properly.

Anyway, I will do to make this merge request :D


A question. How to?

configure metrics to display during learning (which ones, frequency, format etc.)

@yell
Copy link
Owner

yell commented Mar 5, 2019

Please have a look here: https://github.com/monsta-hd/boltzmann-machines/blob/master/boltzmann_machines/rbm/base_rbm.py#L53-L72

SrMouraSilva added a commit to SrMouraSilva/boltzmann-machines that referenced this issue Mar 6, 2019
@yell yell closed this as completed in #9 Mar 6, 2019
yell added a commit that referenced this issue Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants