Skip to content

Commit

Permalink
remove more ancient stuff, in this case, OpenBSD 5.9 compat vlan code
Browse files Browse the repository at this point in the history
  • Loading branch information
yellowman committed May 2, 2021
1 parent 9396b73 commit 02f31bb
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 89 deletions.
1 change: 0 additions & 1 deletion commands.c
Expand Up @@ -534,7 +534,6 @@ struct intlist Intlist[] = {
{ "carppeer", "CARP peer", CMPL0 0, 0, intcarp },
{ "balancing", "CARP balancing mode", CMPL0 0, 0, intcarp },
{ "pflow", "pflow data export", CMPL0 0, 0, intpflow },
{ "vlan", "802.1Q vlan tag and parent", CMPL0 0, 0, intvlan }, /* XXX bkcompat */
{ "debug", "Driver dependent debugging", CMPL0 0, 0, intflags },
{ "dhcrelay", "DHCP Relay Agent", CMPL0 0, 0, intdhcrelay },
{ "wol", "Wake On LAN", CMPL0 0, 0, intxflags },
Expand Down
2 changes: 1 addition & 1 deletion conf.c
Expand Up @@ -603,7 +603,7 @@ void conf_vnetid(FILE *output, int ifs, char *ifname)

if (((vnetid = get_vnetid(ifs, ifname)) != 0))
if (vnetid < 0)
fprintf(output, " vnetid any\n", vnetid);
fprintf(output, " vnetid any\n");
else
fprintf(output, " vnetid %lld\n", vnetid);
}
Expand Down
1 change: 0 additions & 1 deletion externs.h
Expand Up @@ -397,7 +397,6 @@ int intdhcrelay(char *, int, int, char **);
int intmetric(char *, int, int, char **);
int intllprio(char *, int, int, char **);
int intrtd(char *, int, int, char **);
int intvlan(char *, int, int, char **);
int intflags(char *, int, int, char **);
int intxflags(char *, int, int, char **);
int intaf(char *, int, int, char **);
Expand Down
86 changes: 0 additions & 86 deletions if.c
Expand Up @@ -1530,92 +1530,6 @@ intllprio(char *ifname, int ifs, int argc, char **argv)
return(0);
}

int
intvlan(char *ifname, int ifs, int argc, char **argv)
{
#ifndef SIOCSIFPARENT /* 5.9- */
const char *errmsg = NULL;
struct ifreq ifr;
struct vlanreq vreq;
#endif
int set;

if (NO_ARG(argv[0])) {
set = 0;
argc--;
argv++;
} else
set = 1;

argc--;
argv++;

if ((set && argc != 3) || (!set && argc > 3) ||
(argc == 3 && !isprefix(argv[1], "parent"))) {
printf("%% vlan <tag> parent <parent interface>\n");
printf("%% no vlan [tag] [parent <parent interface>]\n");
return 0;
}

#ifndef SIOCSIFPARENT /* 5.9- */
strlcpy(ifr.ifr_name, ifname, sizeof(ifr.ifr_name));

bzero(&vreq, sizeof(vreq));

ifr.ifr_data = (caddr_t)&vreq;

if (ioctl(ifs, SIOCGETVLAN, (caddr_t)&ifr) == -1) {
switch(errno) {
case ENOTTY:
printf("%% This interface does not support vlan"
" tagging\n");
break;
default:
printf("%% intvlan: SIOCGETVLAN: %s\n",
strerror(errno));
}
return(0);
}
#endif
if (set) {
if (!is_valid_ifname(argv[2]) || is_bridge(ifs, argv[2])) {
printf("%% Invalid vlan parent %s\n", argv[2]);
return 0;
}
#ifndef SIOCSIFPARENT /* 5.9- */
strlcpy(vreq.vlr_parent, argv[2], sizeof(vreq.vlr_parent));
vreq.vlr_tag = strtonum(argv[0], 0, 4095, &errmsg);
if (errmsg) {
printf("%% Invalid vlan tag %s: %s", argv[0], errmsg);
return 0;
}
if (vreq.vlr_tag != EVL_VLANOFTAG(vreq.vlr_tag)) {
printf("%% Invalid vlan tag %s\n", argv[0]);
return 0;
}
} else {
bzero(&vreq.vlr_parent, sizeof(vreq.vlr_parent));
vreq.vlr_tag = 0;
#endif
}

if (set) {
char *vnet_argv[] = { "vnetid", argv[0], NULL };
char *par_argv[] = { "parent", argv[2], NULL };

intparent(ifname, ifs, 2, par_argv);
intvnetid(ifname, ifs, 2, vnet_argv);
} else {
char *vnet_argv[] = { "no", "vnetid" };
char *par_argv[] = { "no", "parent" };

intparent(ifname, ifs, 2, par_argv);
intvnetid(ifname, ifs, 2, vnet_argv);
}

return 0;
}

int
intgroup(char *ifname, int ifs, int argc, char **argv)
{
Expand Down

0 comments on commit 02f31bb

Please sign in to comment.