Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Old props and children added as argument to custom component patch method #3

Merged
merged 1 commit into from Oct 19, 2017
Merged

Old props and children added as argument to custom component patch method #3

merged 1 commit into from Oct 19, 2017

Conversation

andriichumak
Copy link
Contributor

  • Added oldProps and oldChildren parameters to custom component patch method;
  • Switch argument places in shouldUpdate method to keep it consistent with path method.

@andriichumak
- Added oldProps and oldChildren parameters to custom component patch…
8c64595 
… method;

- Switch argument places in shouldUpdate method to keep it consistent with path method.
@andriichumak
Copy link
Contributor Author

This is for #2

@yelouafi yelouafi merged commit 1748786 into yelouafi:master Oct 19, 2017
@yelouafi
Copy link
Owner

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andriichumak @yelouafi