Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent analyze_string return values #14

Closed
KevinHock opened this issue Apr 6, 2018 · 0 comments
Closed

Inconsistent analyze_string return values #14

KevinHock opened this issue Apr 6, 2018 · 0 comments
Assignees

Comments

@KevinHock
Copy link
Collaborator

KevinHock commented Apr 6, 2018

So right now the private_key plugin returns a dictionary of the form {'filename':PotentialSecret}, whereas the high_entropy_strings plugin returns a dictionary of the form {PotentialSecret.__hash()__: PotentialSecret}. We should change this to be the same, I lean towards the {PotentialSecret.__hash()__: PotentialSecret} because I think the rest of the code assumes this. So e.g.

-            output[filename] = PotentialSecret(
+            secret = PotentialSecret(
                 self.secret_type,
                 filename,
                 line_num,
                 string,
             )
+            output[secret] = secret
@KevinHock KevinHock self-assigned this Apr 6, 2018
jimmyhlee94 pushed a commit to jimmyhlee94/detect-secrets that referenced this issue Aug 19, 2021
Fix GHE host authenticity issue with Travis build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant