Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[audit functionality] Handle Unicode better #71

Closed
KevinHock opened this issue Aug 27, 2018 · 1 comment
Closed

[audit functionality] Handle Unicode better #71

KevinHock opened this issue Aug 27, 2018 · 1 comment
Labels
good first issue The issue can be tackled by someone who has little to no knowledge about the project. help wanted Indicates that we would like someone that’s not a maintainer to work on the issue.

Comments

@KevinHock
Copy link
Collaborator

Someone reported to us the following redacted stacktrace:

...detect_secrets/core/audit.py", line 347, in _highlight_secret
    secret_line[index_of_secret + len(raw_secret):],
UnicodeEncodeError: 'ascii' codec can't encode character u'\xef' in position 51: ordinal not in range(128)
@KevinHock KevinHock added help wanted Indicates that we would like someone that’s not a maintainer to work on the issue. good first issue The issue can be tackled by someone who has little to no knowledge about the project. labels Sep 12, 2018
@killuazhu killuazhu mentioned this issue Feb 12, 2019
Merged
@KevinHock
Copy link
Collaborator Author

This should have been fixed by @killuazhu's wonderful linked #129 PR :D 🎉 🎂 🎈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue The issue can be tackled by someone who has little to no knowledge about the project. help wanted Indicates that we would like someone that’s not a maintainer to work on the issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KevinHock