Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unicode error during audit #129

Merged
merged 1 commit into from
Feb 12, 2019

Conversation

killuazhu
Copy link
Contributor

Fix an issue when it is Unicode in a file containing secret, the audit would fail with UnicodeEncodeError.

Fix an issue when there is unicode in a file containing secret,
the audit would fail with UnicodeEncodeError
@killuazhu
Copy link
Contributor Author

I don't know the exact source file which fails #71, but I think the fix here would also fix #71

Copy link
Collaborator

@KevinHock KevinHock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me 🚢 ✈️

@KevinHock
Copy link
Collaborator

(just waiting for travis, which seems to be having some timeout issues)

@KevinHock KevinHock merged commit 9d324bc into Yelp:master Feb 12, 2019
@KevinHock
Copy link
Collaborator

(Bumped version)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants