Skip to content
This repository has been archived by the owner on Jul 31, 2019. It is now read-only.

yelp_clog should acquire the logging lock with a timeout #29

Closed
paiweilai opened this issue Dec 2, 2016 · 0 comments
Closed

yelp_clog should acquire the logging lock with a timeout #29

paiweilai opened this issue Dec 2, 2016 · 0 comments

Comments

@paiweilai
Copy link

If we have been asked to log lines with a timeout, we probably shouldn't block forever waiting to acquire the RLock in the _log_line_no_size_limit method. Instead we probably want to just fail to log the line.
Basically we need to change this code to not block forever on the lock.

@tub tub closed this as completed Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants