Make namespace resolution safer

[whitlockjc]

• Instead of blindly turning a file extension into a RegExp, we now
  escape the input using escape-string-regexp. Since it was already
  in use, it was a non-issue.
• This is a follow up to Fix namespace resolution for paths with more than one '.js' in it #31. Fix namespace resolution for paths with more than one '.js' in it #31 fixed the immediate problem but left
  yeoman-environment in the same state it was before. This should make
  namespace resolution safer.

[coveralls]

Coverage remained the same at 91.77% when pulling 5f66726 on whitlockjc:safer-namespace-identification into 765664a on yeoman:master.

[whitlockjc]

The good ole Coveralls.io 422...

[SBoudrias]

Actually, I though about this before merging, but as . will match any character and we know we replace the last ($) occurrence of the file extension, then we know for sure we'll always match the . character.

Just saying this won't change the behavior, but it is safer for eventual future changes.

[whitlockjc]

I agree completely, just happy to help.

[SBoudrias]

@whitlockjc If you feel like helping some more, we've had an issue open for some time about fixing our unit tests (the global NODE_PATH that bit you yesterday) #4 - or really any issues opened with the actionnable tag.

[whitlockjc]

I'll take a look.