Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for yarn linked generators #86

Merged
merged 1 commit into from Aug 9, 2017

Conversation

appsforartists
Copy link
Contributor

lib/resolver.js Outdated
// To ensure `yarn global add yo` and `yarn link generator-i-made` work as
// expected, add the `link` folder to path if we appear to be installed in
// yarn's global tree.
if (path.basename(path.join(__dirname, '../../../../')) === 'yarn') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason/tradeoff to not add paths.push('~/.config/yarn/link/') directly? I feel that'd be simpler and less tricky

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I wrote this immediately after I woke up and didn't realize there was an absolute path. Will send fix.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I mean this could've been for a reason - like maybe yarn wouldn't always use the same config folder or something. But alright, I'm happy with the simpler solution :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly don't know much about yarn installations on other machines.

The original solution would be safer if it moved around, but I don't know if it does.

@SBoudrias
Copy link
Member

Thanks for your help! I'll publish a new release by the evening in my TZ.

@SBoudrias
Copy link
Member

And it's released as 2.0.2 - thanks again for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants