This repository has been archived by the owner on Mar 26, 2018. It is now read-only.
Allow customised application name #187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.appname = path.basename(process.cwd()); | ||
| } | ||
| this.appname = this._.slugify(this._.humanize(this.appname)); | ||
|
|
There was a problem hiding this comment.
this looks like something that should be in generator core. // @SBoudrias
There was a problem hiding this comment.
Yeah, we could automatically check for app name when Generator is instantiated.
What would have priority, bower.json or package.json?
There was a problem hiding this comment.
Sounds good, is there anything I can pick up with this or are you guys onto it?
There was a problem hiding this comment.
Feel free to send a PR on the generator system.
|
As we've asked for this to go into the core generator system, can this PR be closed now? |
|
Sure, I'll clean it up and reopen there. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I commented on an old closed issue but have had to address this myself for a project I am working on and wanted to raise it again here.
I need to be able to set the main application namespace to that of something other than the root directory. The usage section of the Readme implies that this is already supported by supplying an optional name when generating the app but this is ignored.
I've followed the angular generator which uses the app name argument when generating the app and then pulls the name from the bower.json for sub-generator actions. I can add tests if you are willing to pull this in as a feature, if not I suggest changing the docs to prevent other's frustration.