-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Options in collection method? #23
Comments
I vote for this discussion to be moved to grunt-init-jquery since this generator was built based on it. |
@zenorocha Makes sense. Should I create a new issue there, then? Thanks! |
yep ;) |
No, let's keep the discussion here. grunt-init is effectively unmaintained and nothing will come out of discussing there. |
As of #39, that's not really true anymore. |
@arthurvr I haven't used this generator in awhile; your PR looks totally like what I was wanting though. Can I effectively close this issue then? |
If I am not understanding you wrong, yup! |
Awesome, thanks! 😄 |
Hi!
The generator scaffolds out a collection method, a static method, default options for the static method and a custom selector. In order to use the static method's default options in the collection method, I'm guessing I'd pass an options argument and then do
options = $.extend({}, $.myplugin.options, options);
like is done in the static method?If so, this should maybe be clarified (or options passed to the collection method as they're currently done to the static method). I'm not a total neophyte in terms of writing jQuery plugins, but I found the scaffolded code confusing enough to stop me for a moment...
The text was updated successfully, but these errors were encountered: