Handle failing github-username properly

yeoman · Oct 18, 2016 · efe25b9 · efe25b9
1 parent 2a0d11c
commit efe25b9
Showing 1 changed file with 14 additions and 11 deletions.
diff --git a/generators/app/index.js b/generators/app/index.js
@@ -184,18 +184,21 @@ module.exports = generators.Base.extend({
         return;
       }
 
-      return githubUsername(this.props.authorEmail).then(function (err, username) {
-        if (err) {
-          username = username || '';
-        }
-        return this.prompt({
-          name: 'githubAccount',
-          message: 'GitHub username or organization',
-          default: username
-        }).then(function (prompt) {
-          this.props.githubAccount = prompt.githubAccount;
+      return githubUsername(this.props.authorEmail)
+        .then(function (username) {
+          return username;
+        }, function () {
+          return '';
+        })
+        .then(function (username) {
+          return this.prompt({
+            name: 'githubAccount',
+            message: 'GitHub username or organization',
+            default: username
+          }).then(function (prompt) {
+            this.props.githubAccount = prompt.githubAccount;
+          }.bind(this));
         }.bind(this));
-      }.bind(this));
     }
   },