Fixed missing package name in generated cli.js

[petersandor]

this.options.name was undefined since CLI generator doesn't have any name option specified.

[SBoudrias]

Please add a unit test. We want to make sure this won't break if someone run yo node --cli and yo node:cli.

[petersandor]

Thanks, I added a basic test that compares whether the name variable contains anything. By the way, seems like yo node --cli just runs the main app generator - even before my changes.

[SBoudrias]

yo node --cli will run the main generator and then compose the node:cli generator

[SBoudrias]

If we're not using the --name anymore, we should remove it.

[petersandor]

Actually using --name works. I wasn't aware of that, my mistake. I did not provide and it still ran without errors, I guess some check for that might be useful.

edit: it is not mentioned in --help and I looked there, nevermind I guess this PR can be closed. Thanks for quick help.

[SBoudrias]

I don't think it should be close. We have (or should have) access to the app name without requiring someone to manually pass an option.

The interface will be better if we can just figure that value out without user input.

[petersandor]

I'm closing this PR since there is a possibility to provide --name to avoid the issue (#133), as a new user I was not aware of it, since it wasn't mentioned in --help.

I think two things need to be done:

1. Mention --name in subgenerator --help
2. If --name isn't provided, use this.appname as a default

I will leave the issue open for discussion. Thanks @SBoudrias for the quick feedback. 👍