Bring back line ending correction

[mischah]

Relates to #257, #251

Must say that I’m not sure if I’m super happy with that because using the line ending corrector was a no brainer before. It was bundled into the gulp default task as well as the watch task.

So I’m asking what to do about it.
Ideas:

• Document that with more details in the README?
  • I guess people won’t read this 😕
• Add an additional npm script like build ?
  • So the scripts section could look like:

    "scripts": {
        "prepublish": "nsp check",
        "pretest": "eslint **/*.js --fix",
        "test": "jest",
        "fixLineEndings": "lec lib/cli.js"
        "build": "npm run fixLineEndings && npm test"
    }
    

Any feedback appreciated 😗

[zckrs]

Initialy we fix line endings in a prepublish gulp task.

So

"scripts": {
    "prepublish": "lec lib/cli.js && nsp check",
    "pretest": "eslint **/*.js --fix",
    "test": "jest"
}

[mischah]

Jup, also thought about that.
But Isn’t it a bit weird to run a CLI App which potentially changes files in the »prepublish« phase?

Reason: This might change a file which make it in the changed state into your npm release but the changes aren’t in your version control at this time 😳

Get what I’m trying to say?

[zckrs]

This might change a file which make it in the changed state into your npm release but the changes aren’t in your version control at this time

Agree 🤔

[SBoudrias]

But that's how it was before. This really is a hot fix for a common mistake that'll break a package on OSx

[mischah]

Alright. Pushed another commit to change that.

[SBoudrias]

great :)