Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect bootstrap script tags #337

Merged
merged 1 commit into from
Jun 17, 2015

Conversation

jaromero
Copy link
Contributor

Currently in the index.html file, the bootstrap script tags are mistakenly generated with the type attribute instead of src, like this (which prevents them from loading and actually working):

<script type="/bower_components/bootstrap-sass/assets/javascripts/bootstrap/affix.js"></script>
<script type="/bower_components/bootstrap-sass/assets/javascripts/bootstrap/alert.js"></script>
<script type="/bower_components/bootstrap-sass/assets/javascripts/bootstrap/dropdown.js"></script>
<script type="/bower_components/bootstrap-sass/assets/javascripts/bootstrap/tooltip.js"></script>
...

and so on.

This PR fixes this and updates the tests to make sure that the src attribute is used.

@silvenon
Copy link
Member

Lol, I suck 😛 Thanks for catching and fixing this 👍

silvenon added a commit that referenced this pull request Jun 17, 2015
@silvenon silvenon merged commit eade976 into yeoman:master Jun 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants