fix watch: livereload css #56

Closed
wants to merge 1 commit into from

5 participants

@levito

Notify livereload about compiled css change, not scss. This prevents a race condition and simplifies things.

@levito levito fix watch: livereload css
notify livereload about compiled css change, not scss
b8a559f
@passy
Yeoman member

Not tested, but looks reasonable. +1

@sindresorhus
Yeoman member

Afaik scss isn't compiled into that dir.

@addyosmani
Yeoman member

@passy did you have a chance to test this? Reading through, I have the same comment @sindresorhus did. I don't think the scss is getting compiled into the directory this PR suggests it is.

@passy
Yeoman member
@silvenon
Yeoman member

The PR is correct, SCSS files are getting compiled to the same directory. #47 is correcting that, because it's weird :D

This is a good way to go because you don't want CSS injected when the SCSS is modified (common mistake), you want it injected when SCSS is compiled.

@sindresorhus
Yeoman member

closing in favor of #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment