Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix watch: livereload css #56

Closed
wants to merge 1 commit into from
Closed

fix watch: livereload css #56

wants to merge 1 commit into from

Conversation

levito
Copy link
Contributor

@levito levito commented Apr 2, 2014

Notify livereload about compiled css change, not scss. This prevents a race condition and simplifies things.

notify livereload about compiled css change, not scss
@passy
Copy link
Member

passy commented Apr 3, 2014

Not tested, but looks reasonable. +1

@sindresorhus
Copy link
Member

Afaik scss isn't compiled into that dir.

@addyosmani
Copy link
Member

@passy did you have a chance to test this? Reading through, I have the same comment @sindresorhus did. I don't think the scss is getting compiled into the directory this PR suggests it is.

@passy
Copy link
Member

passy commented Apr 6, 2014

@addyosmani I'll have another look. Thanks for the ping.
On Apr 6, 2014 1:37 PM, "Addy Osmani" notifications@github.com wrote:

@passy https://github.com/passy did you have a chance to test this?
Reading through, I have the same comment @sindresorhushttps://github.com/sindresorhusdid. I don't think the scss is getting compiled into the directory this PR
suggests it is.


Reply to this email directly or view it on GitHubhttps://github.com//pull/56#issuecomment-39667279
.

@silvenon
Copy link
Member

silvenon commented Apr 9, 2014

The PR is correct, SCSS files are getting compiled to the same directory. #47 is correcting that, because it's weird :D

This is a good way to go because you don't want CSS injected when the SCSS is modified (common mistake), you want it injected when SCSS is compiled.

@sindresorhus
Copy link
Member

closing in favor of #47

SBoudrias pushed a commit that referenced this pull request Feb 15, 2016
Upgraded to bower 0.9 glossary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants