Skip to content
This repository has been archived by the owner on May 25, 2019. It is now read-only.

Make sourcemap actually works #539

Closed
wants to merge 1 commit into from
Closed

Conversation

stevemao
Copy link
Collaborator

@stevemao stevemao commented May 1, 2015

There are other ways to do it but this is probably the easiest way because it avoids changing the routes.

@sindresorhus
Copy link
Member

Can you elaborate how it wasn't working and how this fixes it?

@stevemao
Copy link
Collaborator Author

stevemao commented May 1, 2015

When choosing ruby-sass the sourcemap option is not enabled. When choosing node-sass the sources url is different from the routes of the server so it cannot find the sources. We should either change the routes of the server or just make the source inline.

@stevemao
Copy link
Collaborator Author

stevemao commented May 1, 2015

This PR makes the sources inline because we have bower_components, .tmp and app/style folders so it might be harder to change the server routes.

@stevemao
Copy link
Collaborator Author

Since ruby-sass is removed this is actually more simple

@stevemao
Copy link
Collaborator Author

60c2735

@stevemao stevemao closed this Jun 28, 2015
@silvenon
Copy link
Member

Damn, I spend many hours fixing this only to come to the same fix which was here all along. Sorry, I didn't see it, but I will give you credit in the release notes for v0.6.1. Thanks for solving it!

@stevemao
Copy link
Collaborator Author

Lol no worries. There is some slight difference. Your approach also embeds the sass sourcemap, and let autoprefixer pick up the previous sourcemap by setting it to true. I was trying to keep it as close to the original workflow as possible.

@silvenon
Copy link
Member

Released v0.6.1.

Yeah, I wanted to mimic generator-gulp-webapp and thought that there might be less potential problems in the future if sourcemap was inline.

@stevemao
Copy link
Collaborator Author

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants