This repository has been archived by the owner on May 25, 2019. It is now read-only.
Make Babel flag default=false #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of 34453b8, Babel is now an option under the `--babel` flag. However because it is [set to true by default](yeoman/generator-webapp@34453b8#diff-2018087f584c4398b5c3a23fc0e5f9dbR21), there doesn't seem to be a way to turn it off so it's effectively compulsory. (Am I correct in this? I tried `--babel=false` and consulted the Yeoman docs, but I can't find a way to set the flag to false.) If Babel is supposed to be optional then shouldn't it be off by default? Else use a prompt instead.
|
Nice catch! Thanks 👍 |
silvenon
added a commit
that referenced
this pull request
Jun 28, 2015
Make Babel flag default=false
|
Released in v0.6.1. |
|
A |
|
Thanks 👍 We want to have it on by default, so in the next minor/major release we will implement it either as an option (with improved docs) or a prompt. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of 34453b8, Babel is now an option under the
--babelflag. However because it is set to true by default, there doesn't seem to be a way to turn it off so it's effectively compulsory. (Am I correct in this? I tried--babel=falseand consulted the Yeoman docs, but I can't find a way to set the flag to false.)If Babel is supposed to be optional then shouldn't it be off by default? Else use a prompt instead.