Merge a756477 into 8d50cd8

yeoman · Feb 19, 2020 · ecd307b · ecd307b
2 parents 8d50cd8 + a756477
commit ecd307b
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/lib/index.js b/lib/index.js
@@ -625,6 +625,9 @@ class Generator extends EventEmitter {
         })()
           .then(function() {
             delete self.runningState;
+            const eventName = `done$${namespace || 'unknownnamespace'}#${methodName}`;
+            debug(`Emiting event ${eventName}`);
+            self.env.emit(eventName, namespace, self);
             completed();
           })
           .catch(err => {

diff --git a/test/generators.js b/test/generators.js
@@ -7,15 +7,20 @@ const os = require('os');
 
 const Base = require('..');
 
+const NAMESPACE = 'somenamespace';
+
 describe('Generators module', () => {
   beforeEach(function() {
     this.env = Environment.createEnv();
   });
 
   describe('Base', () => {
     beforeEach(function() {
-      this.generator = new Base({
+      const Generator = class extends Base {};
+      Generator.prototype.exec = function() {};
+      this.generator = new Generator({
         env: this.env,
+        namespace: NAMESPACE,
         resolved: 'test'
       });
     });
@@ -27,6 +32,15 @@ describe('Generators module', () => {
       this.generator.on('yay-o-man', done);
       this.generator.emit('yay-o-man');
     });
+
+    it('emits done event', function(done) {
+      this.env.on(`done$${NAMESPACE}#exec`, (id, generator) => {
+        assert(generator === this.generator);
+        assert(`done$${NAMESPACE}#exec`.includes(id));
+        done();
+      });
+      this.generator.run();
+    });
   });
 
   it('without localConfigOnly option', function() {