Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to tell if bower isn't installed #871

Closed
grawk opened this issue Nov 13, 2015 · 8 comments
Closed

How to tell if bower isn't installed #871

grawk opened this issue Nov 13, 2015 · 8 comments

Comments

@grawk
Copy link
Contributor

grawk commented Nov 13, 2015

I'm experimenting with the variable of bower not being installed for a user who is using my generator. It seems like installBower will not report this condition. Is there a recommended approach to handle this scenario?

@sindresorhus
Copy link
Member

That method should probably check first if Bower is installed and warn if not.

@SBoudrias
Copy link
Member

We could totally change our install method to do:

  1. Check if install tool is installed
  2. No? Then we post install information
  3. Yes? Run tool install

@mischah
Copy link
Member

mischah commented Nov 23, 2015

mhmm. Isn’t that already implemented over here?
https://github.com/yeoman/generator/blob/master/lib/actions/install.js#L48-L53

@sindresorhus
Copy link
Member

@mischah Wild guess, maybe the exit code isn't always 127 and the code path isn't hit.

@eddiemonge
Copy link
Member

Looks like its throwing 0 currently.

Maybe just a general message like: There was a problem running installer. Make sure it is installed and the install command works.

@mischah
Copy link
Member

mischah commented Oct 16, 2016

I’m going to try to fix that :octocat:

@addyosmani
Copy link
Member

Thanks!

@mischah
Copy link
Member

mischah commented Oct 17, 2016

Thanks!

My Pleasure. PR over here: #967

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants