Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NamedBase deprecation message is confusing #886

Closed
gruppjo opened this issue Dec 17, 2015 · 3 comments
Closed

NamedBase deprecation message is confusing #886

gruppjo opened this issue Dec 17, 2015 · 3 comments

Comments

@gruppjo
Copy link
Contributor

gruppjo commented Dec 17, 2015

Hi and thanks for the new release :)

I just upgraded to yeoman-generator v.0.22.1 and got deprecation warnings.

(!) require('yeoman-generator').generators.Base is deprecated. Use require('yeoman-generator').Base directly

I kept looking for lines of code that used generators.Base but there were none. It took me a while to find out that generators.NamedBase is also deprecated. Turns out that they were the cause for the deprecation warnings, which I found misleading, since generators.Base was mentioned in the deprecation warnings.

@rosegbn
Copy link

rosegbn commented Jan 6, 2016

I also encountered that when I installed npm i -g generator-webapp.

@SBoudrias
Copy link
Member

a PR to make the message more helpful is welcomed!

@mischah
Copy link
Member

mischah commented Oct 17, 2016

I’m going to submit a PR to fix that :octocat:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants