Don't die on diffing file deletions (again) #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes `null` content (file deletion): 1. not identify as binary (so default diff style is nicer) 2. not break binary diff if it is Addresses regression(?) of yeoman#950
|
CI fail doesn't look related to my changes |
|
Thanks, I'll take review the code this weekend. |
|
Hey, not sure what happened, but there's no indentation in the files you edited? Mind fixing that? |
|
Huh. Could you be more specific? The diff on Github LGTM, and
|
|
Looking fine today, must've been a Github bug the other day... |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
nullcontent (file deletion):Addresses regression(?) of #950