New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit error instead of throwing it. #1155

Merged

SBoudrias merged 1 commit into yeoman:master from mshima:assert

Jan 24, 2020

Member

mshima commented Jan 22, 2020

The error is thrown outside the runLoop, so it's not properly emitted.


          Emit error instead of throwing it.

1ba62d0

This happens outside the runLoop, so it's not properly emitted.

This was referenced Jan 22, 2020

Add catch error test case. yeoman/yeoman-test#66

Closed

Generator 4.5.0 release #1152

Closed

SBoudrias approved these changes

View reviewed changes

Member

SBoudrias commented Jan 24, 2020

Ah good find!

SBoudrias merged commit 690cb59 into yeoman:master

mshima deleted the assert branch

January 26, 2020 13:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment