Fixed RangeError: Maximum call stack size exceeded for Windows

[royling]

The same issue was posted and discussed in google maillist, but not fixed.
Root cause: file name on Windows is case insensitive.

[coveralls]

Coverage decreased (-0.06%) when pulling 8a8dc98 on RoyLING:patch-1 into c77412f on yeoman:master.

[addyosmani]

In our experience most of the problems here come down to insufficient permissions (at least, the issue linked to on the list had this as a core problem). Are you running into this when logged in as an admin?

[royling]

@addyosmani Initially the problem was encountered when running any yo command, I googled the problem and found the related discussion in the googlegroup maillist (closed now, so I cannot reopen the discussion by replying to it). There the final solution was to do the things in Git bash client instead of windows cmd / powershell (I didn't try this yet). But I think this is only a workaround, not solution (that's why I made the change and sent the pull request), so I dived into the code and did some debugging, figured out that the basedir and path.resolve('/') were actually refer to the same path, but 2 string values in different case (in my case, basedir is in lower case (ie. c:/), while the other is in upper case), then it falled into the infinite recursions, resulted to the RangeError.
I don't think this problem has anything to do with the permission. On windows, it's not allowed to create 2 files/folders with names only in different case (e.g. mkdir tmp vs. mkdir Tmp), unlike linux.

[coveralls]

Coverage increased (+0.01%) when pulling 05fe8a5 on RoyLING:patch-1 into c77412f on yeoman:master.

[SBoudrias]

This is weird because I use windows a lot and I never got this bug.

Is it possible in Linux to create two directory with different cases? e.g. mkdir Hey && mkdir hey - it is not possible on mac.

I wouldn't mind adding a check, but the proposed solution is really not expressive.

[royling]

@SBoudrias It's possible to have 2 dirs only with different cases in Linux...
Are you running yo command in windows powershell or cmd? I got the error even when running yo --help.

[sindresorhus]

Let's fix this. We don't want to care about case-sensitive paths.

[SBoudrias]

Agreed, just compare both path to lower case without any OS check. And squash your commits together after.

[royling]

I did run yo cmd in node v0.11.x and yesterday I learned that yeoman is recommended to work on node stable version (0.10). Is this true? Anyway, I will downgrade node and see if the problem still exists or not.

[royling]

Update: With node v0.10.22, the error was not encountered, yo works well. So for now, I think we could discard the change.