-
-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First stab at gulp #448
First stab at gulp #448
Conversation
@SBoudrias nice! yeah, just an oversight on my end. try 0.1.1 ;) |
var mocha = require('gulp-mocha'); | ||
var jshint = require('gulp-jshint'); | ||
var jscs = require('gulp-jscs'); | ||
var istanbul = require('gulp-istanbul'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not in npm so i guess you're working on this :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, almost got it working. There's just a bug that it only check coverage of one files, I'll fix it and publish the module soon. :)
Apparently linting and jscs errors doesn't break travis build (exit is still 0). I wonder if failing tests would? (probably since you |
Couple of comments:
|
As for the process exit code it depends on the plugin. The guidelines specify that plugins need to emit all errors as an |
I've updated the mocha and jscs plugins to emit an error event on error. |
@contra Would it be possible gulp implement something like |
@SBoudrias Well right now (at least in event-stream which most plugins use) it will keep going even after an error event has been emitted as long as it was caught. Theoretically (I personally haven't done it) by adding an empty |
Well, everything seems to be working great with Gulp - Awesome! I'll merge. |
Woot! |
@SBoudrias the coveralls stuff kinda feel like it should be a node module or gulp thing. |
@sindresorhus It looks like it would make a good |
@sindresorhus @contra Sure, it could even fit in a I just wanted to get this working today. We'll be able to extract it later. |
@sindresorhus I'm having trouble making
jscs
works, it can't find the.jscs.json
file. Any idea why?