Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First stab at gulp #448

Merged
merged 1 commit into from
Dec 30, 2013
Merged

First stab at gulp #448

merged 1 commit into from
Dec 30, 2013

Conversation

SBoudrias
Copy link
Member

@sindresorhus I'm having trouble making jscs works, it can't find the .jscs.json file. Any idea why?

@sindresorhus
Copy link
Member

@SBoudrias nice! yeah, just an oversight on my end. try 0.1.1 ;)

@sindresorhus sindresorhus mentioned this pull request Dec 28, 2013
var mocha = require('gulp-mocha');
var jshint = require('gulp-jshint');
var jscs = require('gulp-jscs');
var istanbul = require('gulp-istanbul');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not in npm so i guess you're working on this :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, almost got it working. There's just a bug that it only check coverage of one files, I'll fix it and publish the module soon. :)

@SBoudrias
Copy link
Member Author

Apparently linting and jscs errors doesn't break travis build (exit is still 0).

I wonder if failing tests would? (probably since you mocha.run them mocha would throw a non 0 exit)

@yocontra
Copy link

Couple of comments:

  • I usually define all of my paths as variables just to keep things DRY between tasks.
  • I would move the coveralls stuff into another function or package
  • The mocha stuff can probably be its own task as well (trigger with .run('mocha', cb))

@yocontra
Copy link

As for the process exit code it depends on the plugin. The guidelines specify that plugins need to emit all errors as an error event so users can handle them. If this were true the node process should fail (exit code 1) due to throwing the error (default behavior when no listeners for error are present).

@sindresorhus
Copy link
Member

I've updated the mocha and jscs plugins to emit an error event on error.

@SBoudrias
Copy link
Member Author

@contra Would it be possible gulp implement something like grunt --force so tasks continues running even though some throws? This is good when you want a full output of the issues encountered.

@yocontra
Copy link

@SBoudrias Well right now (at least in event-stream which most plugins use) it will keep going even after an error event has been emitted as long as it was caught. Theoretically (I personally haven't done it) by adding an empty process.on('uncaughtException') you can keep it going even if something fails

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.98%) when pulling a4d8186 on SBoudrias:gulp into 7e1e7ee on yeoman:master.

@SBoudrias
Copy link
Member Author

Well, everything seems to be working great with Gulp - Awesome! I'll merge.

@SBoudrias SBoudrias merged commit a4d8186 into yeoman:master Dec 30, 2013
@SBoudrias SBoudrias deleted the gulp branch December 30, 2013 02:43
@sindresorhus
Copy link
Member

Woot!

@sindresorhus
Copy link
Member

@SBoudrias the coveralls stuff kinda feel like it should be a node module or gulp thing.

@yocontra
Copy link

@sindresorhus It looks like it would make a good gulpfriendly module

@SBoudrias
Copy link
Member Author

@sindresorhus @contra Sure, it could even fit in a stream module if we pipe it to the lcov.info file.

I just wanted to get this working today. We'll be able to extract it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants