Change configstore dependency version to 2.0.0 #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,9 +1,10 @@ | |||
| { | |||
| "name": "update-notifier", | |||
| "version": "0.6.2", | |||
| "version": "0.6.3", | |||
There was a problem hiding this comment.
Don't bump versions. Package maintainers will take care of it.
|
Squash your commits and we'll be good to merge. |
hemanth
added a commit
that referenced
this pull request
Mar 17, 2016
Change configstore dependency version to 2.0.0
|
On behalf of Simon ;) |
| @@ -4,6 +4,7 @@ | |||
| "description": "Update notifications for your CLI app", | |||
| "license": "BSD-2-Clause", | |||
| "repository": "yeoman/update-notifier", | |||
| "bugs": "https://github.com/yeoman/update-notifier/issues", | |||
There was a problem hiding this comment.
This should also not have been part of the PR... It's out of scope and not needed as npm infers it from the repo field.
sindresorhus
added a commit
that referenced
this pull request
Mar 17, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #72.
According to the release notes of configstore, there has been added support for dot notations. Since update-notifier does not use dots in its config values, this should be fine by just changing the referenced version.