Improve typing of RunResult #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mischah
requested changes
Jan 19, 2023
Improve typing of RunResult: - Add default for generator type in RunResult - Improve typing in helpers to make typescript better at infering generator type
|
You are right, I needed to propagate the changes in type to a few other methods, the type errors are fixed when running the tests localy, I hope it will be the same on CI. |
mischah
approved these changes
Jan 20, 2023
|
Trusting @mischah review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 2 changes:
RunResultin places where we don't care of the type of the generator.hepers.create(MyGenerator), typescript will now correctly infer the result asRunResult<MyGenerator>