Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapping up #27 #37

Closed
wants to merge 11 commits into from
Closed

Wrapping up #27 #37

wants to merge 11 commits into from

Conversation

ericduran
Copy link
Member

Changes all the include to now use content from the wiki.

  • Added new Wiki submodule
  • Removed old yeoman/yeoman.git submodule since it's no longer needed
  • Updated submoduleupdate.sh script to update the wiki when run.

@ericduran
Copy link
Member Author

cc @sindresorhus : FYI, this one is wrapped up. 👍

@paulirish
Copy link
Member

Tight. so all these docs are coming in from https://github.com/yeoman/yeoman/wiki/_pages now

@ericduran
Copy link
Member Author

Whoops I messed up the git submodule path.

@ericduran
Copy link
Member Author

Damn it everything works locally but I have a feeling it's not going to work on gh-pages.

Here's the issue. The wiki git repo doesn't seem to work as read-only. This is very mis-leading because github provides a url but when you try to clone that url it fails.

I'm currently using the http url (https://github.com/yeoman/yeoman.wiki.git) but according to Github Pages (https://help.github.com/articles/using-submodules-with-pages) the url must be the git:// read-only url.

:-/ That's a lot of work that might end up being useless :'(

@ericduran
Copy link
Member Author

cc @paulirish & @sindresorhus see what you guys think.

The way I see it, I failed in not catching this early.

@paulirish
Copy link
Member

:(

Eric, ping support@github.com and cc me? If its true they don't have
readonly then.. i'm very confused. :/

On Fri, Jan 11, 2013 at 3:10 PM, Eric J. Duran notifications@github.comwrote:

cc @paulirish https://github.com/paulirish & @sindresorhushttps://github.com/sindresorhussee what you guys think.

The way I see it, I failed in not catching this early.


Reply to this email directly or view it on GitHubhttps://github.com//pull/37#issuecomment-12168115.

@sindresorhus
Copy link
Member

git clone git://github.com/yeoman/yeoman.wiki.git
Cloning into 'yeoman.wiki'...
fatal: remote error: access denied or repository not exported: /4/nw/41/ba/21/4012544/4012544.wiki.git

@sindresorhus
Copy link
Member

@sindresorhus
Copy link
Member

@ericduran Seems like the clone problem was fixed. Works for me now.

@ericduran
Copy link
Member Author

This this is now a wrap.

I had to update all the path because of the changes in mention in yeoman/yeoman#812 (comment)

This is good to get merged in.

@ericduran ericduran closed this in fd2d76b Jan 23, 2013
@sindresorhus
Copy link
Member

@ericduran Landed. Great work on this. Thanks so much! 🍰

@ericduran
Copy link
Member Author

👍

@ericduran ericduran deleted the wiki-sub branch January 24, 2013 02:07
@paulirish
Copy link
Member

A true yeoman's work. Thanks Eric for making this so hot. 👯

@ericduran
Copy link
Member Author

np :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants