Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show outdated generators in yoyo #57

Merged
merged 1 commit into from Jul 14, 2013
Merged

Conversation

stephenplusplus
Copy link

RE: #55

The first commit is a sync version, where it checks every time yo runs.

The second commit checks once every 24 hours.

@stephenplusplus
Copy link
Author

Oh, and the sync version will only work with update-notifier@master. A release hasn't been made with the callback support yet.

@sindresorhus
Copy link
Member

I don't want a sync version unless we can update the prompt lazily when after it has loaded. @SBoudrias possible?

@sindresorhus
Copy link
Member

Nice work @stephenplusplus I like how it looks.

@SBoudrias
Copy link
Member

Not possible - at least yet. Could be a nice API to add on Inquirer.

@addyosmani
Copy link
Member

I'm not a fan of the sync version but nice start on this otherwise. When
once a day does it actually run the update check? On first run?

Lets spend some time trying this PR out in practice before merging. Need to
review commits but my concerns are impact update checks have on perf.

On Thursday, July 11, 2013, Simon Boudrias wrote:

Not possible - at least yet. Could be a nice API to add on Inquirer.


Reply to this email directly or view it on GitHubhttps://github.com//pull/57#issuecomment-20826910
.

Sent from Gmail Mobile

@sindresorhus
Copy link
Member

When
once a day does it actually run the update check? On first run?

Every 24 hours based on the last check.

Need to
review commits but my concerns are impact update checks have on perf.

Update notifier async was designed to have no impact on perf (or anything) at all since everything is executed in separate process.

@addyosmani
Copy link
Member

Re-reviewed this. It's actually really nice to use in practice :) Merging!

addyosmani added a commit that referenced this pull request Jul 14, 2013
Show outdated generators in `yoyo`
@addyosmani addyosmani merged commit dbacafd into yeoman:master Jul 14, 2013
@passy
Copy link
Member

passy commented Jul 14, 2013

🍰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants