Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser requires meta object #184

Closed
Logicer16 opened this issue Mar 30, 2024 · 7 comments · Fixed by #185
Closed

Parser requires meta object #184

Logicer16 opened this issue Mar 30, 2024 · 7 comments · Fixed by #185
Labels
bug Something isn't working

Comments

@Logicer16
Copy link

Logicer16 commented Mar 30, 2024

When attempting to use @html-eslint/parser, eslint --cache throws an error as the parser lacks a meta object:

Error: Could not serialize parser object (missing 'meta' object).

Config (eslint.config.js):

import htmlPlugin from "@html-eslint/eslint-plugin";
export default [
  htmlPlugin.configs["flat/recommended"]
];
@yeonjuan yeonjuan added the enhancement New feature or request label Mar 31, 2024
@yeonjuan
Copy link
Owner

Thanks for the report, it looks like we need to change the parser to export the meta object.

@Logicer16
Copy link
Author

Logicer16 commented Mar 31, 2024

Did you mean to tag this as a bug instead of an enhancement? This is a fatal error being thrown. The parser does not work in a flat config.

@yeonjuan
Copy link
Owner

yeonjuan commented Apr 1, 2024

Hi @Logicer16. I tried flat config and couldn't see any errors, could you please share your eslint version?

Did you mean to tag this as a bug instead of an enhancement? This is a fatal error being thrown.

Right, I'll change the label. Thanks!

@yeonjuan yeonjuan added bug Something isn't working and removed enhancement New feature or request labels Apr 1, 2024
@Logicer16
Copy link
Author

Logicer16 commented Apr 1, 2024

I tried flat config and couldn't see any errors

I've taken a look, it only seems to be an issue when either --cache or --print-config is used. That's probably why it wasn't noticed earlier.

@yeonjuan
Copy link
Owner

yeonjuan commented Apr 3, 2024

@Logicer16

I've taken a look, it only seems to be an issue when either --cache or --print-config is used. That's probably why it wasn't noticed earlier.

I've confirmed that the error you mentioned is reproduced! Thanks for the details. I'll fix it up and release it this weekend, but if you're planning to contribute yourself, let me know. I look forward to it.

@yeonjuan
Copy link
Owner

yeonjuan commented Apr 6, 2024

Hi @Logicer16 , It's fixed and released in @html-eslint/parser@0.24.1 , @html-eslint/eslint-plugin@0.24.1. thanks!

@Logicer16
Copy link
Author

Thank you so much! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants