Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "regex" option to id-naming-convention #166

Merged
merged 5 commits into from
Dec 5, 2023

Conversation

seleb
Copy link
Contributor

@seleb seleb commented Dec 5, 2023

hey there! i ran into a case where id-naming-convention rule would be helpful, but the provided options are too strict to easily adopt (it's a large repo with multiple competing standards). this updates the rule to support a custom regex, which should hopefully make it flexible enough to cover any cases which deviate from the common standards

Copy link
Owner

@yeonjuan yeonjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @seleb Thanks for the contribution! The new options seems nice.
Could you update the docs? - docs/rules/id-naming-convention.md

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #166 (feba696) into main (81c7e48) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #166   +/-   ##
=======================================
  Coverage   98.27%   98.27%           
=======================================
  Files          47       47           
  Lines        1099     1102    +3     
  Branches      282      285    +3     
=======================================
+ Hits         1080     1083    +3     
  Misses         19       19           
Flag Coverage Δ
unittest 98.27% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...es/eslint-plugin/lib/rules/id-naming-convention.js 90.90% <100.00%> (+1.43%) ⬆️

Copy link
Owner

@yeonjuan yeonjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seleb LGTM! Thanks !! Will be released this weekend

@yeonjuan yeonjuan merged commit b73cfe5 into yeonjuan:main Dec 5, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants