Remove sdk_version from default login parameters #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of 2019-08-29 login requests that contain this field fail with Error=UNKNOWN_ERR. This commit removes the field and updates the tests accordingly. See NoMore201/googleplay-api#93
|
The CI build fails during setup phase, unrelated to the changes in this PR. If you'd like to fix the CI build before merging this PR, merge #41 first and rebase this PR on top of it. |
This was referenced Aug 30, 2019
|
Please merge this and create a release, when you have time @yeriomin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of 2019-08-29 login requests that contain this field fail
with Error=UNKNOWN_ERR.
This commit removes the field and updates the tests accordingly.
See NoMore201/googleplay-api#93