Merge pull request #195 from yermak/development

Fixed ogg metadata
yermak · Jan 4, 2021 · d48c082 · d48c082
2 parents a43c741 + 19d30f1
commit d48c082
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 16 deletions.
diff --git a/README.md b/README.md
@@ -4,6 +4,14 @@ Official web-site
 <a href="https://www.recoupler.com/products/audiobookconverter">Recoupler AudioBookConverter</a>
 
 
+Version 5.5.8 - released!
+
+https://github.com/yermak/AudioBookConverter/releases/tag/version_5.5.8
+
+GitHub does not show it as the latest :(
+
+
+
 AudioBookConverter
 ===============
 AudioBookConverter was originally designed as simple and lightweigh application to convert set of mp3 files to single m4b (aac) file to be played on your i-device (or any device now)

diff --git a/src/main/java/uk/yermak/audiobookconverter/Format.java b/src/main/java/uk/yermak/audiobookconverter/Format.java
@@ -42,15 +42,15 @@ public List<String> getReencodingOptions(MediaInfo mediaInfo, String progressUri
             options.add("-vn");
             options.add("-codec:a");
             options.add(codec);
-            options.add("-f");
-            options.add(format);
+
+            options.add("-map_metadata");
+            options.add( "-1");
 
             options.addAll(outputParameters.cbr
                     ? List.of("-b:a", outputParameters.getBitRate() + "k")
                     : List.of("-q:a", String.valueOf(10 - outputParameters.vbrQuality * 2))
             );
 
-
             options.add("-ac");
             options.add(String.valueOf(outputParameters.getChannels()));
             if (mediaInfo.getOffset() != -1) {
@@ -61,6 +61,8 @@ public List<String> getReencodingOptions(MediaInfo mediaInfo, String progressUri
                 options.add("-cutoff");
                 options.add(Integer.toString(outputParameters.getCutoff()));
             }
+            options.add("-f");
+            options.add(format);
             options.add("-progress");
             options.add(progressUri);
             options.add(outputFileName);
@@ -215,8 +217,9 @@ public List<String> getReencodingOptions(MediaInfo mediaInfo, String progressUri
             options.add("-vn");
             options.add("-codec:a");
             options.add(codec);
-            options.add("-f");
-            options.add(format);
+
+            options.add("-map_metadata");
+            options.add( "-1");
 
             if (outputParameters.cbr) {
                 options.addAll(List.of("-b:a", outputParameters.getBitRate() + "k"));
@@ -236,6 +239,9 @@ public List<String> getReencodingOptions(MediaInfo mediaInfo, String progressUri
                 options.add("-cutoff");
                 options.add(Integer.toString(outputParameters.getCutoff()));
             }
+            options.add("-f");
+            options.add(format);
+
             options.add("-progress");
             options.add(progressUri);
             options.add(outputFileName);
@@ -325,10 +331,14 @@ public List<String> getReencodingOptions(MediaInfo mediaInfo, String progressUri
         options.add("-vn");
         options.add("-codec:a");
         options.add(codec);
-        options.add("-f");
-        options.add(format);
 
-        addBitrateAndQuality(outputParameters, options);
+        options.add("-map_metadata");
+        options.add( "-1");
+
+        options.addAll(outputParameters.cbr
+                ? List.of("-b:a", outputParameters.getBitRate() + "k")
+                : List.of("-q:a", String.valueOf(0.5 + outputParameters.vbrQuality * outputParameters.vbrQuality * 0.06))
+        );
 
         options.add("-ac");
         options.add(String.valueOf(outputParameters.getChannels()));
@@ -340,19 +350,15 @@ public List<String> getReencodingOptions(MediaInfo mediaInfo, String progressUri
             options.add("-cutoff");
             options.add(Integer.toString(outputParameters.getCutoff()));
         }
+        options.add("-f");
+        options.add(format);
+
         options.add("-progress");
         options.add(progressUri);
         options.add(outputFileName);
         return options;
     }
 
-    protected void addBitrateAndQuality(OutputParameters outputParameters, List<String> options) {
-        options.addAll(outputParameters.cbr
-                ? List.of("-b:a", outputParameters.getBitRate() + "k")
-                : List.of("-q:a", String.valueOf(0.5 + outputParameters.vbrQuality * outputParameters.vbrQuality * 0.06))
-        );
-    }
-
     public List<String> getTranscodingOptions(MediaInfo mediaInfo, String progressUri, String outputFileName) {
         List<String> options = new ArrayList<>();
         options.add(Utils.FFMPEG);

diff --git a/version.txt b/version.txt
@@ -1 +1 @@
-AudioBookConverter-5.5.4
+AudioBookConverter-#{APP_VERSION}#