Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show recalculated (based on speed) duration for the original file and for chapter #221

Merged
merged 4 commits into from
Jan 29, 2021
Merged

Show recalculated (based on speed) duration for the original file and for chapter #221

merged 4 commits into from
Jan 29, 2021

Conversation

isdenmois
Copy link
Contributor

No description provided.

yermak
yermak requested changes Jan 29, 2021
View reviewed changes
Copy link
Owner

@yermak yermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update MediaInfoAdaptor as well.
Proxy will not be enough

@isdenmois
Copy link
Contributor Author

@yermak Added duration calculation to MediaTrackAdaptor.
BTW, there was a bug when we extract subtracts with selected speed -- the start and end of Track were set with wrong intervals. We need to use original intervals there, so I've added a fix for that as well.

@isdenmois isdenmois requested a review from yermak January 29, 2021 17:44
@yermak yermak merged commit cdb60c6 into yermak:development Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yermak yermak Awaiting requested review from yermak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@isdenmois @yermak