Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dssp shoudn't include spdlog's bundled fmt. #26

Closed
patlefort opened this issue Aug 12, 2021 · 4 comments
Closed

dssp shoudn't include spdlog's bundled fmt. #26

patlefort opened this issue Aug 12, 2021 · 4 comments

Comments

@patlefort
Copy link

In dssp.cpp and structure.cpp, it should include fmt/printf.h instead. It create problems for packagers because spdlog is installed without a bundled fmt and it uses the system's fmt.

@patlefort patlefort changed the title dssp shoudn't include spdlog bundled fmt. dssp shoudn't include spdlog's bundled fmt. Aug 12, 2021
@yesint
Copy link
Owner

yesint commented Aug 13, 2021

I've added fmt as an explicit dependency and dropped the usage of fmt bundled with spdlog. Please test.

@patlefort
Copy link
Author

It's working, thank you.

@patlefort
Copy link
Author

Another small aside: You should make your release tags annotated so that people can be notified via github.

@yesint
Copy link
Owner

yesint commented Aug 13, 2021

Thank you for suggestion! This is an important point.

@yesint yesint closed this as completed Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants