-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dssp shoudn't include spdlog's bundled fmt. #26
Comments
patlefort
changed the title
dssp shoudn't include spdlog bundled fmt.
dssp shoudn't include spdlog's bundled fmt.
Aug 12, 2021
I've added fmt as an explicit dependency and dropped the usage of fmt bundled with spdlog. Please test. |
It's working, thank you. |
Another small aside: You should make your release tags annotated so that people can be notified via github. |
Thank you for suggestion! This is an important point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In
dssp.cpp
andstructure.cpp
, it should includefmt/printf.h
instead. It create problems for packagers because spdlog is installed without a bundled fmt and it uses the system's fmt.The text was updated successfully, but these errors were encountered: