Add computed position types #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendanzab
commented
Oct 25, 2018
| @@ -430,6 +432,7 @@ impl Default for TcEnv { | |||
| let var_offset64be = FreeVar::fresh_named("Offset64Be"); | |||
|
|
|||
| let var_array = FreeVar::fresh_named("Array"); | |||
| let var_offset_pos = FreeVar::fresh_named("OffsetPos"); | |||
There was a problem hiding this comment.
Not really sold on this naming... computed stuff kind hurts my brain :/
|
Still need some parse tests for this stuff |
brendanzab
commented
Oct 29, 2018
src/semantics/env.rs
Outdated
| @@ -785,6 +800,18 @@ impl GlobalEnv for TcEnv { | |||
| _ => None, | |||
| }) | |||
| } | |||
|
|
|||
| fn offset_pos<'a>(&self, ty: &'a RcType) -> Option<(u64, &'a BigInt, &'a RcType)> { | |||
| free_var_app(&self.globals.var_array, ty).and_then(|spine| match spine { | |||
There was a problem hiding this comment.
BAHAHA! Copy-pastey bug here: s/var_array/var_offset_pos/
brendanzab
force-pushed
the
brendanzab/computed-pos
branch
from
8f3c873
to
a6fb915
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.