Update to use resourcet >= 1.0 #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resourcet-1.0 doesn't have the `MonadUnsafeIO` class anymore, but authenticate-oauth seems to be abusing that anyway. I have instead opted to use `MonadIO` in the cases where `MonadUnsafeIO` was used.
|
Pinging @mlitchard |
|
Ping? I can confirm that our code does at least work with this, so it might be nice to get it in and fix the build even if it has to change later. |
|
Ping... |
|
This should really be merged in. |
|
Anything new on this? What is the maintenance status of |
|
@meteficha and I are in the process of taking over maintenance of the package. We'll hopefully have more information soon. |
|
Can you confirm that this is resolved by #39? |
|
I can confirm that "The great authenticate-oauth cleanup" did indeed fix my the issue. You can probably close this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resourcet-1.0 doesn't have the
MonadUnsafeIOclass anymore, butauthenticate-oauth seems to be abusing that anyway. I have instead opted
to use
MonadIOin the cases whereMonadUnsafeIOwas used.