Deprecate mpsGeneric (#1250)

yesodweb · Apr 26, 2021 · 5c424d9 · 5c424d9
1 parent 1075ba2
commit 5c424d9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/persistent/ChangeLog.md b/persistent/ChangeLog.md
@@ -49,6 +49,11 @@
     * Add the `runSqlCommand` function for running arbitrary SQL during
       migrations.
     * Add `migrateModels` function for a TH-free migration facility.
+* [#1250](https://github.com/yesodweb/persistent/pull/1250)
+    * The `mpsGeneric` function has been deprecated. If you need this
+      functionality, please comment with your needs on the GitHub issue tracker.
+      We may un-deprecate it, or we may provide a new and better means of
+      facilitating a solution to your problem.
 
 ## 2.12.1.1
 

diff --git a/persistent/Database/Persist/TH.hs b/persistent/Database/Persist/TH.hs
@@ -588,6 +588,9 @@ data MkPersistSettings = MkPersistSettings
     -- @since 2.13.0.0
     }
 
+
+{-# DEPRECATED mpsGeneric "The mpsGeneric function adds a considerable amount of overhead and complexity to the library without bringing significant benefit. We would like to remove it. If you require this feature, please comment on the linked GitHub issue, and we'll either keep it around, or we can figure out a nicer way to solve your problem.\n\n Github: https://github.com/yesodweb/persistent/issues/1204" #-}
+
 -- |  Set the 'ImplicitIdDef' in the given 'MkPersistSettings'. The default
 -- value is 'autoIncrementingInteger'.
 --