Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persistent on GHC 8.2.2 #1181

Merged
merged 5 commits into from
Jan 6, 2021
Merged

Persistent on GHC 8.2.2 #1181

merged 5 commits into from
Jan 6, 2021

Conversation

Vlix
Copy link
Contributor

@Vlix Vlix commented Jan 2, 2021 •
edited
Loading

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

Make Github actions also test GHC 8.2.2 and GHC 8.4.4 (and the fixes to make it compile)

Postgresql's PersistLiteral tests don't succeed for me locally, and I'm not sure if that's just my settings or that something's gone wrong?

@Vlix
Copy link
Contributor Author

Vlix commented Jan 2, 2021

Addressing #1180

@parsonsmatt
Copy link
Collaborator

going to wait for this to pass CI since there was a code-level change in the GitHub merge

@parsonsmatt parsonsmatt merged commit daa80bf into yesodweb:master Jan 6, 2021
@Vlix Vlix deleted the persistent-on-8.2.2 branch January 8, 2021 14:10
@parsonsmatt parsonsmatt mentioned this pull request Apr 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vlix @parsonsmatt