Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function onlyOneUniqueDef not exported #1194

Closed
erikd opened this issue Feb 25, 2021 · 0 comments
Closed

Function onlyOneUniqueDef not exported #1194

erikd opened this issue Feb 25, 2021 · 0 comments
Milestone

Comments

@erikd
Copy link
Contributor

erikd commented Feb 25, 2021

The function onlyOneUniqueDef is defined in Database.Persist.Class.PersistUnique but that module is private.

The function also does not seem to be used anywhere else in the project, making me thing it was meant to be exported. It also has a @since 2.10.0 annotation, suggesting that it was intended to be exported.

@parsonsmatt parsonsmatt added this to the 2.13 milestone May 4, 2021
parsonsmatt added a commit that referenced this issue May 5, 2021
* Internalize SqlBackend (#1225)

* abstractification

* abstractification

* Internalize SqlBackend

* suppor tother sql dbs

* bounds

* asdf

* import data.monoid

* limitoffset and backendspecificoverrides

* use setter

* getConnUpsertSql

* formatting

* sigh

* clean warns

* cabal formatting

* merge resolve

* lol

* ok

* update changelogs

* one more [ci skip]

* Implicit ID Column Configuration (#1234)

* Implicit ID Column COnfiguration

* PersistSettings is internal

* start teasing out the module structure

* move around, factor out the Names module

* start enumerating types, make entitydef abstract

* entity def abstraction

* teasing out the EntityDef stuff

* builds

* testinggg

* it works

* it works

* tidy up

* sigh

* i hate you

* tidy

* wrote test for mysql, need to set maxlen sigh

* mysql test, need to be able to set maxlen

* support mysql lmfao

* whyyy

* Deprecate mpsGeneric (#1250)

* discoverEntities (#1253)

* discover entities

* remove fdescribe

* changelog

* yupo

* remove error

* Fix migrations (#1252)

* Better migrations

* why is the test failing

* Columns are present in entityFields now, but the generated code is broken.

* th specs work

* fixed mkColumns

* changelog entry

* fix mongo

* no idea why this is broken now

* why on earth did this work

* remove debug trace statements

* typo

* what no put that back in

* Check for existence of entities before generating them (#1255)

* wtf

* hmmm

* refactor and tidy

* are foreign fields never right ?!

* changelog

* fix comments

* dead code

* Implement config for customising the FK name (#1244)

* Implement config for customising the FK name

* Update changelog

* Tweak test description

* Tweaks/better use of types

* Review tweaks

* Some initial post-review changes

* Table name turned out to be EntityNameHS

* Do the same thing but for the constraint

* Expose more stuff

* Some refactoring / cleanup

* Fix changelog indentation

* Tidy code layout

* QuasiQuoter Improvements (#1256)

* QQ now returns UnboundEntityDef

* Relocate fixForeignKeysAll

* deprecate some stuff, reorganize some code

* ok, now we need to set sql types appropriately.

* dodgy instances are banned

* fuse away the EntityDefSqlTypeExp stuff

* refactor to top level

* fuse sqlTypeExp in there

* fix Key vs Id stuff

* still need to get the foreign key types right

* hmmm

* move to QuasiSpec

* clean up tests

* so close

* ok but what if i don't fix foreign keys

* wip

* oh man please

* getting closer...

* make some tests

* fix json and keyFromValueM

* slightly more graceful handling

* return dummy field for id, from persist values

* got some tests passing

* well sqlite works

* pg tests running

* what happened

* hmm mongo is trashed maybe

* bye mongo

* ok for real bye mongo, for now at least

* clean warns

* asdf

* drop GHC 8.2 support

* sigh

* lots of commments

* Merge branch 'master' into persistent-2.13 (#1261)

* Reexport PersistValue

* fix json for MigrationOnly

* Export onlyOneUniqueDef (fixes #1194)

* use onlyOneUniqueDef in persistent-postgresql

Co-authored-by: Dan Brooks <danbroooks@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants