Incorrect shadowed name warning

[erikd]

For a trivial schema definition (with persistent 2.14.0.1):

share
  [ mkPersist sqlSettings
  , mkMigrate "migrateCardanoDb"
  , mkEntityDefList "entityDefs"
  , deriveShowFields
  ]
  [persistLowerCase|

  SchemaVersion
    stageOne Int
    stageTwo Int
    stageThree Int
    deriving Eq
  |]

I an getting strange shadowed name warnings like:

rc/Cardano/Db/Schema.hs:47:1: error: [-Wname-shadowing, -Werror=name-shadowing]
    This binding for ‘schemaVersionStageTwo’ shadows the existing binding
      defined at src/Cardano/Db/Schema.hs:47:1
   |
47 | share
   | ^^^^^...

src/Cardano/Db/Schema.hs:47:1: error: [-Wname-shadowing, -Werror=name-shadowing]
    This binding for ‘schemaVersionStageThree’ shadows the existing binding
      defined at src/Cardano/Db/Schema.hs:47:1
   |
47 | share
   | ^^^^^...

src/Cardano/Db/Schema.hs:47:1: error: [-Wname-shadowing, -Werror=name-shadowing]
    This binding for ‘schemaVersionStageOne’ shadows the existing binding
      defined at src/Cardano/Db/Schema.hs:47:1
   |
47 | share
   | ^^^^^...

src/Cardano/Db/Schema.hs:47:1: error: [-Wname-shadowing, -Werror=name-shadowing]
    This binding for ‘schemaVersionStageThree’ shadows the existing binding
      defined at src/Cardano/Db/Schema.hs:47:1
   |
47 | share
   | ^^^^^...

src/Cardano/Db/Schema.hs:47:1: error: [-Wname-shadowing, -Werror=name-shadowing]
    This binding for ‘schemaVersionStageOne’ shadows the existing binding
      defined at src/Cardano/Db/Schema.hs:47:1
   |
47 | share
   | ^^^^^...

src/Cardano/Db/Schema.hs:47:1: error: [-Wname-shadowing, -Werror=name-shadowing]
    This binding for ‘schemaVersionStageTwo’ shadows the existing binding
      defined at src/Cardano/Db/Schema.hs:47:1
   |
47 | share
   | ^^^^^...

This worked up until version 2.14. Adding the constraint persistent < 2.13.3.4 makes it build again.

[erikd]

I suspect this is related to #1379 but I am not sure of the fix.

[parsonsmatt]

Good find, thanks for reporting! I'll dig into this

[parsonsmatt]

Released in 2.14.0.2

[brandonchinn178]

FYI For people looking at this after the fact, the bug was introduced in 2.13.3.4

[merijn]

I think there was a regression or incomplete fix, because I'm seeing this exact same error and same cause (duplicated names in patterns) on 2.14.4, example generated code obtained via dump-splices:

      Database.Persist.Class.PersistEntity.keyFromRecordM
        = Just
            (\ StepPropValue {stepPropValueVariantId = stepPropValueVariantId,
                              stepPropValueStepId = stepPropValueStepId,
                              stepPropValueProperty = stepPropValueProperty}
               -> ((StepPropValueKey stepPropValueVariantId) stepPropValueStepId)
                    stepPropValueProperty)

[merijn]

I suspect #1460 is too blame, because the code for that fix touches the same code that was touched by this fix?

[merijn]

Nevermind, 2.14.4.3 has the same issue for me, so it's not #1460 and possibly the original problem wasn't completely fixed?