persistent: Test failure on 32-bit arches with GHC 9.0.2

[swt2c]

Over in Debian unstable, we're seeing a test failure on all 32-bit architectures (armel, armhf, i386, mipsel) when building persistent 2.13.3.5:

Failures:

  test/Database/Persist/THSpec.hs:240:26: 
  1) Database.Persist.THSpec.HasIdDef should have correct underlying sql type
       expected: SqlInt64
        but got: SqlInt32

  To rerun use: --match "/Database/Persist/THSpec/HasIdDef/should have correct underlying sql type/"

Randomized with seed 10835329

Finished in 0.2322 seconds
231 examples, 1 failure, 3 pending
Test suite test: FAIL
Test suite logged to: dist-ghc/test/persistent-2.13.3.5-test.log

The tests are passing on 64-bit architectures (amd64, arm64, mips64el, ppc64el, s390x).

Full build logs for armel are available here: https://buildd.debian.org/status/fetch.php?pkg=haskell-persistent&arch=armel&ver=2.13.3.5-1&stamp=1659384152&raw=0

[swt2c]

Ping - anything we can do to help debug/fix this issue?

[parsonsmatt]

I think this will do it: https://github.com/yesodweb/persistent/pull/1429/files

The test assumed that Int is represented in SQL as a 64 bit integer, but the instance actually cases on "how many bits are in an Int", and on 32 bit platforms, that's obviously 32.

I don't have a means for testing on 32 bit machines. Since it is a "test suite bug" I would recommend not running tests on 32 bit machines for this package until that PR is merged and a release including it is made.

[swt2c]

Thanks for the quick fix! I can probably test it on a 32-bit machine...

[swt2c]

Tested on an i386 chroot, now I'm seeing two failures:

Failures:

  test/Database/Persist/THSpec.hs:216:26: 
  1) Database.Persist.THSpec.HasDefaultId should have correct underlying sql type
       expected: SqlInt32
        but got: SqlInt64

  To rerun use: --match "/Database/Persist/THSpec/HasDefaultId/should have correct underlying sql type/"

  test/Database/Persist/THSpec.hs:244:26: 
  2) Database.Persist.THSpec.HasIdDef should have correct underlying sql type
       expected: SqlInt64
        but got: SqlInt32

  To rerun use: --match "/Database/Persist/THSpec/HasIdDef/should have correct underlying sql type/"

Randomized with seed 2106055493

Finished in 0.2276 seconds
231 examples, 2 failures, 3 pending
Test suite test: FAIL
Test suite logged to: dist-ghc/test/persistent-2.13.3.5-test.log
0 of 1 test suites (0 of 1 test cases) passed.

Looking at your patch, though, it seems that perhaps the change should have been applied in the HasIdDef section, not the `HadDefaultId' section?

[swt2c]

Yep, a slightly modified patch seems to work:
https://salsa.debian.org/haskell-team/DHG_packages/-/blob/master/p/haskell-persistent/debian/patches/fix-tests-32-bit