Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add insertUnique_ #1457

Closed
joeyh opened this issue Dec 26, 2022 · 1 comment
Closed

add insertUnique_ #1457

joeyh opened this issue Dec 26, 2022 · 1 comment

Comments

@joeyh
Copy link
Contributor

joeyh commented Dec 26, 2022

Thanks to #1449, insert_ is around 2x faster than insert. insertUnique uses insert, but in my code I have several places where I use void $ insertUnique because I don't care if a value was already in the database. It follows that an insertUnique_ that uses insert_ would be a performance improvement.
@lbseale lbseale mentioned this issue Jan 27, 2023
Merged
7 tasks
@joeyh
Copy link
Contributor Author

joeyh commented Mar 31, 2023

This was fixed in persistent-2.14.5.0/

@joeyh joeyh closed this as completed Mar 31, 2023
github-actions bot pushed a commit to datalad/git-annex that referenced this issue Mar 31, 2023
@joeyh
Sped up sqlite inserts 2x when built with persistent 2.14.5.0
cc36c85 
yesodweb/persistent#1457

Sponsored-by: Dartmouth College's DANDI project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joeyh