-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added explicit forall notation to make TypeApplications easier to use #1006
added explicit forall notation to make TypeApplications easier to use #1006
Conversation
The CI is failing because of something in MongoDB? |
That's a really strange failure... |
All builds using stack work with no problem, but built with cabal, it breaks on a missing |
I suspect we're missing an upper bound somewhere... |
Try merging master - there's an upper bound in place to prevent the cabal solver from picking that version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks! I'm going to see if there are some other breaking changes we can roll into this release.
…stent into better-typeapplication-order
I'm trying to add some tests, but it's all really annoying. |
I guess one way to do it, would be to not export the class methods in Then again, there are only a few functions that anyone might actually use with |
I wouldn't worry about tests for this. It's not like it can be broken. You'd only really want to specify the |
Well, I did anyway. But yeah, |
I think Well. Hmm! Maybe it is worthwhile to have the class methods separate from the functions in the API. It's a breaking change, but all of this is a breaking change anyway. |
Ah true, Do you want me to add the |
looking forward to merging this <3 |
This is a PR for issue #869
Before submitting your PR, check that you've:
After submitting your PR: